fix: spaces in measure/dim search #8490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Dec 12, 2025
Comment on lines
+39
to
+40
| .map((id) => { | ||
| const itemData = allItemsMap.get(id); |
Contributor
There was a problem hiding this comment.
This avoids a redundant map lookup:
.map(([id, itemData]) => ({
id: id!,
displayName: itemData?.displayName ?? id!,
}));
Comment on lines
50
to
51
| .map(([id]) => { | ||
| const itemData = allItemsMap.get(id!); |
mindspank
added a commit
that referenced
this pull request
Dec 13, 2025
* fix: spaces in measure/dim search * fix loop * revert
k-anshul
pushed a commit
that referenced
this pull request
Dec 18, 2025
* fix: spaces in measure/dim search * fix loop * revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure we handle spaces in searches for measure and dims
Checklist: