feat: add themeMode to iframe request #8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Dec 12, 2025
admin/server/deployment.go
Outdated
Comment on lines
756
to
758
| if req.ThemeMode != "light" && req.ThemeMode != "dark" && req.ThemeMode != "system" { | ||
| return nil, status.Error(codes.InvalidArgument, "theme_mode must be one of: light, dark, system") | ||
| } |
Contributor
There was a problem hiding this comment.
If you go with validation in the proto, you don't need this
Co-authored-by: Benjamin Egelund-Müller <[email protected]>
mindspank
force-pushed
the
feat/theme-dark-mode-iframe
branch
from
ccc53ae to
fcc466f
Compare
k-anshul
pushed a commit
that referenced
this pull request
Dec 18, 2025
* feat: add themeMode to iframe request * Update proto/rill/admin/v1/api.proto Co-authored-by: Benjamin Egelund-Müller <[email protected]> * validate in proto * new proto * new proto * proto --------- Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
themeModeto the iframe requestChecklist: