Skip to content

Don't reconcile on ref updates when there's a cron trigger #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
begelundmuller merged 3 commits into from
Dec 16, 2025
Merged

Don't reconcile on ref updates when there's a cron trigger #8479

begelundmuller merged 3 commits into from
Dec 16, 2025

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 10, 2025 •
edited
Loading

  • Previously, refresh.ref_update always defaulted to true unless explicitly overridden. This meant we'd always trigger on a ref update, even when refresh.cron was set.
  • This PR changes the behavior so refresh.ref_update defaults to false when refresh.cron is provided.
  • This is a behavioral change, but perhaps worth it since it will avoid some unintended refreshes. It was originally reported as a bug where an alert with a daily cron schedule was triggering every hour due to the underlying source refresh. But this change impacts the behavior of refresh: across alerts, reports and models.

Closes https://linear.app/rilldata/issue/PLAT-326/alert-cron-jobs-are-not-being-honored

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Dec 10, 2025
@begelundmuller begelundmuller mentioned this pull request Dec 10, 2025
Closed
8 tasks
@begelundmuller begelundmuller merged commit 86a4564 into main Dec 16, 2025
10 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/ref-update-only-if-no-cron branch December 16, 2025 11:33
k-anshul pushed a commit that referenced this pull request Dec 18, 2025
@begelundmuller @k-anshul
Don't reconcile on ref updates when there's a cron trigger (#8479)
0bb4105 
* Test

* Chicken out on behavior change for models

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees

@begelundmuller begelundmuller

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@begelundmuller @k-anshul