feat: mention support in developer chat #8477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
force-pushed
the
feat/mention-support-in-dev-chat
branch
from
bc6dfb2 to
5c2dade
Compare
AdityaHegde
force-pushed
the
feat/mention-support-in-dev-chat
branch
from
6a974a3 to
ec43819
Compare
Di7design
approved these changes
Dec 18, 2025
AdityaHegde
force-pushed
the
feat/mention-support-in-dev-chat
branch
from
0096f76 to
58e7844
Compare
AdityaHegde
force-pushed
the
feat/mention-support-in-dev-chat
branch
from
58e7844 to
1f28f16
Compare
Contributor
Not sure I like the up/down arrow icon here. Is this to indicate you can expand/collapse? If so it might be better to just have the >/v indicators in front of the resource name
|
ericpgreen2
requested changes
Dec 19, 2025
Contributor
ericpgreen2
left a comment
ericpgreen2
left a comment
There was a problem hiding this comment.
UXQA: I'm finding it very hard to use the keyboard to move around in the dropdown menu.
- I type
@to open the menu, I press the down arrow, and I'd expect to move to the second item in the list. Instead, the first metrics view is "opened" and a measure is in focus. Further, sometimes I've found that it focuses a random measure (e.g. see the second image below), not the first one in the list. For inspiration, Cursor does a good job with keyboard navigation in their context picker.
- Sometimes I have to hit the up/down arrow key twice in order to navigate to the next item in the dropdown menu
- When I type
@ad, I see "No matches found". That messaging makes it feel like there's nothing to select. But, in fact, in this case, I can select the metrics view or the model. We should be more specific about what's "not found".
- The resource icons disappear when the resource is in the expanded state (see image above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the mention-like inline context to developer chat.
Adds models and their columns to dev chat for rill developer context. This is the 1st iteration, we will probably add more of these.
Known issue: Using keyboard to move to model doesnt automatically uncollapse it because the options are not loaded. Will do a follow up that does some significant changes to the highlight manager in a separate PR.
Checklist: