Skip to content

Add Ruby 3.1 support and drop Ruby 2.5 support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taichi-ishitani merged 2 commits into from
Dec 31, 2021
Merged

Add Ruby 3.1 support and drop Ruby 2.5 support #33

taichi-ishitani merged 2 commits into from
Dec 31, 2021

Conversation

@taichi-ishitani
Copy link
Member

@taichi-ishitani taichi-ishitani commented Dec 31, 2021

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Dec 31, 2021

Code Climate has analyzed commit 5adae49 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Dec 31, 2021 •
edited
Loading

Codecov Report

Merging #33 (5adae49) into master (57cda5c) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   99.33%   99.55%   +0.21%     
==========================================
  Files          21       21              
  Lines         453      448       -5     
==========================================
- Hits          450      446       -4     
+ Misses          3        2       -1
Impacted Files Coverage Δ
lib/rggen/spreadsheet_loader/spreadsheet_loader.rb 100.00% <0.00%> (ø)
...c/rggen/spreadsheet_loader/spreadsheet/row_spec.rb 100.00% <0.00%> (ø)
...ggen/spreadsheet_loader/spreadsheet_loader_spec.rb 100.00% <0.00%> (ø)
...b/rggen/spreadsheet_loader/spreadsheet/position.rb 71.42% <0.00%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cda5c...5adae49. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@taichi-ishitani taichi-ishitani merged commit f604a55 into master Dec 31, 2021
@taichi-ishitani taichi-ishitani deleted the ruby31_support branch December 31, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taichi-ishitani