Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leftover assert false in code for null != undefined #7232

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix leftover assert false in code for null != undefined #7232

merged 1 commit into from
Jan 6, 2025

Conversation

cristianoc
Copy link
Collaborator

Fixes #7225

@cristianoc cristianoc force-pushed the null_undefined_assert_false branch from dc5ed90 to 3e8512c Compare January 6, 2025 11:46
@cristianoc cristianoc force-pushed the null_undefined_assert_false branch from 3e8512c to 706dafd Compare January 6, 2025 11:48
@cristianoc cristianoc requested review from cknitt and zth January 6, 2025 11:48
@cristianoc cristianoc merged commit 11b2c2d into master Jan 6, 2025
15 of 16 checks passed
@cristianoc cristianoc deleted the null_undefined_assert_false branch January 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cknitt cknitt Awaiting requested review from cknitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler Assertion when comparing null with undefined
2 participants
@cristianoc @zth