Clean up Record_optional_labels #7191
Conversation
cristianoc
force-pushed
the
types-optional-record-fields
branch
from
a793751 to
7fdf2b5
Compare
Clean up Record_optional_labels: determine whether a field is optional directly.
cristianoc
force-pushed
the
clean-up-record-optional-labels
branch
from
4c44e34 to
27678d5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: c02def3 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print RedBlackTreeNoComments.res - time/run |
2.2175484733333333 ms |
2.10057036 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
There's now no global set of optional fields stored anywhere, but optional is attached to each field.
compiler/ml/types.ml
Outdated
| match y with | ||
| | Record_optional_labels lbls2 -> lbls = lbls2 | ||
| | Record_optional_labels -> true |
There was a problem hiding this comment.
The check if the labels are the same can be safely removed here?
There was a problem hiding this comment.
Yes there are no more labels represented here. Each label has its own optionality information.
Later on, we can probably remove the classificationRecord_optional_labels entirely.
There was a problem hiding this comment.
@cknitt take a look: removed Record_optional_labels entirely, now that the information is available directly from the fields.
|
Removed distinction between regular records and records with optional fields from the back-end. |
Which seems actually more correct. 👍 |
| ]; | ||
| } | ||
| break; | ||
| case "xx1" : |
There was a problem hiding this comment.
This case is now (correctly) optimized away, right?
There was a problem hiding this comment.
Not quite.
Fixed.
Clean up Record_optional_labels: determine whether a field is optional directly.