Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ast cleanup exp object, exp unreachable #7189

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc requested review from cknitt and zth December 4, 2024 07:58
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, how come the unreachable stuff is safe to delete? What does it actually do?

@cristianoc
Copy link
Collaborator Author

Curious, how come the unreachable stuff is safe to delete? What does it actually do?

Apparently it's this:
https://stackoverflow.com/questions/52795191/when-are-refutation-cases-necessary-in-ocaml

For which there's no syntax in ReScript.

One could surface that syntax, though wondering whether one should, given it has not surfaced in years of existence of the language.

@zth
Copy link
Collaborator

zth commented Dec 4, 2024

Curious, how come the unreachable stuff is safe to delete? What does it actually do?

Apparently it's this: https://stackoverflow.com/questions/52795191/when-are-refutation-cases-necessary-in-ocaml

For which there's no syntax in ReScript.

One could surface that syntax, though wondering whether one should, given it has not surfaced in years of existence of the language.

Yeah seems like it's fine to get rid of.

@cristianoc cristianoc merged commit b9dd728 into master Dec 4, 2024
20 checks passed
@cristianoc cristianoc deleted the ast-cleanup-exp-object branch December 4, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants