Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: use current compiler #7186

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Tests: use current compiler #7186

merged 4 commits into from
Dec 2, 2024

Conversation

cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Dec 2, 2024

A bunch of tests were based on old version of the compiler.
Move tests to use the current compiler.

@cristianoc cristianoc requested a review from cknitt December 2, 2024 15:11
@@ -95,33 +95,10 @@ and bar = () => foo()

let withDefaultValue = (~paramWithDefault=3, y) => paramWithDefault + y

external unsafe_string1: (bytes, int, int) => Digest.t = "caml_md5_string"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and other files: when there's stuff that does not exist anymore, or e.g. only one component is now supported per file, just removed the code.

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@cristianoc cristianoc enabled auto-merge (rebase) December 2, 2024 18:18
@cristianoc cristianoc merged commit 7da4d6a into master Dec 2, 2024
19 checks passed
@cristianoc cristianoc deleted the tests-use-current-compiler branch December 2, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants