Modernise ast #7185
Merged
Modernise ast #7185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's `Parsetree`, the current parse tree, and `Parsetree0`, the legacy parse tree. Module `Parsetree.Legacy` contains functions to map to the legacy parse tree.
cristianoc
force-pushed
the
modernise_ast
branch
from
532e88b to
f04c857
Compare
When a ppx is applied: 1 Parsetree is converted to Parsetree0 2 the ppx is run 3 the result is converted to Parsetree
cknitt
approved these changes
Dec 3, 2024
|
I'll merge as soon as it's tested on some ppx. |
|
If nobody gets to it before me I'll test it on one of my PPXes, but it might be a day or so before I get time. |
|
I have added a simple ppx test, which will be useful as sanity check to extend when changing the ast more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsetree0.Parsetreecan now be changed and modernised.Ast_mapper_to0andAst_mapper_from0added to convert both ways and maintained wheneverParsetreechanges.Parsetreeis converted to legacyParsetree0, then the ppx is run, then the result is converted back toParsetree.