Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize runtime filenames #7110

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Capitalize runtime filenames #7110

merged 2 commits into from
Oct 20, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 19, 2024

Capitalize runtime filenames (js.res -> Js.res, belt_Array.res -> Belt_Array.res etc.) in preparation for adding Core.

@cknitt cknitt force-pushed the capitalize-runtime branch from 6bd5cfa to f4cad77 Compare October 19, 2024 17:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax Benchmarks

Benchmark suite Current: dd99c22 Previous: e1b7fb7 Ratio
Parse RedBlackTree.res - time/run 1.2213292466666668 ms 1.2123143266666667 ms 1.01
Parse RedBlackTree.res - allocs/run 199057 words 199057 words 1
Print RedBlackTree.res - time/run 2.3082511066666664 ms 2.3104395133333333 ms 1.00
Print RedBlackTree.res - allocs/run 236403 words 236403 words 1
Print RedBlackTreeNoComments.res - time/run 2.0917521333333333 ms 2.10057036 ms 1.00
Print RedBlackTreeNoComments.res - allocs/run 249186 words 249186 words 1
Parse Napkinscript.res - time/run 38.829115859999995 ms 39.28006235333333 ms 0.99
Parse Napkinscript.res - allocs/run 8670066 words 8670066 words 1
Print Napkinscript.res - time/run 72.99102045333333 ms 77.00100409999999 ms 0.95
Print Napkinscript.res - allocs/run 9776327 words 9776327 words 1
Parse HeroGraphic.res - time/run 5.118335793333333 ms 5.13472718 ms 1.00
Parse HeroGraphic.res - allocs/run 1219326 words 1219326 words 1
Print HeroGraphic.res - time/run 8.753934866666667 ms 8.775952553333333 ms 1.00
Print HeroGraphic.res - allocs/run 1396466 words 1396466 words 1

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt changed the title Capitalize runtime files Capitalize runtime file names Oct 20, 2024
@cknitt cknitt changed the title Capitalize runtime file names Capitalize runtime filenames Oct 20, 2024
@cknitt cknitt force-pushed the capitalize-runtime branch from f4cad77 to dd99c22 Compare October 20, 2024 06:36
@cknitt cknitt requested review from zth and cristianoc October 20, 2024 06:40
@cknitt cknitt marked this pull request as ready for review October 20, 2024 07:01
@cknitt cknitt merged commit d924f63 into master Oct 20, 2024
20 checks passed
@cknitt cknitt deleted the capitalize-runtime branch October 20, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants