Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments formatted away in function with no args #7095

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix comments formatted away in function with no args #7095

merged 3 commits into from
Oct 11, 2024

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented Oct 10, 2024

Fix #7085

@shulhi shulhi marked this pull request as ready for review October 10, 2024 12:52
cknitt
cknitt reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

There is a conflict in the CHANGELOG though.

CHANGELOG.md Outdated Show resolved Hide resolved
@shulhi shulhi force-pushed the fix/comments-removed-inside-function-with-no-args branch from f50d0d8 to 096c34d Compare October 11, 2024 00:47
@shulhi shulhi force-pushed the fix/comments-removed-inside-function-with-no-args branch from 096c34d to 9825f95 Compare October 11, 2024 00:48
@cknitt cknitt merged commit b82fbce into rescript-lang:master Oct 11, 2024
20 checks passed
@shulhi shulhi deleted the fix/comments-removed-inside-function-with-no-args branch October 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments formatted away when commenting out function params
2 participants
@shulhi @cknitt