Propagate JSX settings to dependencies #7094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Looks good to me, and I tested it successfully against one of our projects. 👍 I'll hold off merging until we have decided whether to merge #6901 first. |
mununki
force-pushed
the
fix-jsx-settings-inheritance
branch
from
edadeeb to
ac8dadf
Compare
cknitt
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7084
This PR restores previously working JSX settings propagation to dependencies. Now, only propagates JSX 'version' to dependent libraries, preserving their original 'mode' and 'module' settings. This change maintains backwards compatibility while allowing more flexibility in dependency configurations. Added tests to verify correct propagation behavior and dependency setting preservation.