Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -bs-cross-module-opt for tests #7071

Merged
merged 2 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
- Build tests with bsb and move them out of jscomp. https://github.com/rescript-lang/rescript-compiler/pull/7068
- Run `build_tests` on Windows. https://github.com/rescript-lang/rescript-compiler/pull/7065
- Rename folder "jscomp" to "compiler". https://github.com/rescript-lang/rescript-compiler/pull/7086
- Disable -bs-cross-module-opt for tests. https://github.com/rescript-lang/rescript-compiler/pull/7071

# 12.0.0-alpha.3

Expand Down
5 changes: 0 additions & 5 deletions lib/es6/char.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@



function chr(prim) {
return prim;
}

function escaped(param) {
let exit = 0;
if (param >= 40) {
Expand Down Expand Up @@ -83,7 +79,6 @@ function equal(c1, c2) {
}

export {
chr,
escaped,
lowercase_ascii,
uppercase_ascii,
Expand Down
5 changes: 0 additions & 5 deletions lib/js/char.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
'use strict';


function chr(prim) {
return prim;
}

function escaped(param) {
let exit = 0;
if (param >= 40) {
Expand Down Expand Up @@ -82,7 +78,6 @@ function equal(c1, c2) {
return (c1 - c2 | 0) === 0;
}

exports.chr = chr;
exports.escaped = escaped;
exports.lowercase_ascii = lowercase_ascii;
exports.uppercase_ascii = uppercase_ascii;
Expand Down
2 changes: 1 addition & 1 deletion runtime/char.res
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ external code: t => int = "%identity"

external unsafe_chr: int => t = "%identity"

let chr = unsafe_chr
external chr: int => t = "%identity"

external bytes_create: int => array<char> = "Array"

Expand Down
2 changes: 1 addition & 1 deletion runtime/char.resi
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ external code: char => int = "%identity"
Raise [Invalid_argument "Char.chr"] if the argument is
outside the range 0--255. */
@deprecated("Use Core instead. This will be removed in v13")
let chr: int => char
external chr: int => char = "%identity"

/** Return a string representing the given character,
with special characters escaped following the lexical conventions
Expand Down
1 change: 0 additions & 1 deletion tests/tests/rescript.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"in-source": true
},
"bsc-flags": [
"-bs-cross-module-opt",
"-w -3-6-26-27-29-30-32..40-44-45-52-60-9-106+104",
"-warn-error A"
]
Expand Down
3 changes: 2 additions & 1 deletion tests/tests/src/Import.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion tests/tests/src/SafePromises.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 10 additions & 13 deletions tests/tests/src/belt_hashmap_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 5 additions & 6 deletions tests/tests/src/belt_hashset_int_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions tests/tests/src/belt_list_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions tests/tests/src/belt_sortarray_test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 2 additions & 5 deletions tests/tests/src/bench.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading