Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some context to the unused variable warning #7050

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 23, 2024

This adds some very basic context to the unused variable warning. This should be accompanied with a code action to prepend with _ eventually.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet
Why the first suggestion an underscore?
I thought it would be delete. Followed by underscore.

jscomp/ext/warnings.ml Outdated Show resolved Hide resolved
@zth
Copy link
Collaborator Author

zth commented Sep 24, 2024

Sweet Why the first suggestion an underscore? I thought it would be delete. Followed by underscore.

Good point, added that message.

@zth zth enabled auto-merge (squash) September 24, 2024 06:44
@zth zth merged commit 915dc14 into master Sep 24, 2024
19 checks passed
@zth zth deleted the unused-variable-error-message-context branch September 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants