Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for pattern matching mismatches for options/concrete values #7035

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 13, 2024

This expands error messages when matching on options/non-options or non-options/options to better explain what's going wrong, and how you can solve it.

image
image

Part of #6975

@zth zth requested review from cknitt and cristianoc September 13, 2024 12:16
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zth zth enabled auto-merge (squash) September 13, 2024 13:07
@zth zth merged commit a7a1f25 into master Sep 13, 2024
19 checks passed
@zth zth deleted the improve-pattern-type-clash-errors branch September 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants