-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow non-variant spreads in variants #6980
Conversation
Great! Some remarks:
|
This PR disallows using extensible variants.
Yes, sorry, didn't see I reformatted it.
No idea why it changed. I'll try re-running that and see what happens. |
Yes, but @glennsl also wrote
Do we want a syntax for an empty variant type in ReScript? If so, should we open a separate issue for that? |
Oh, right. Feels like a separate topic to this, so yes, a separate issue would be good. |
@cknitt seems to have done it. Would you look again? |
a8eb622
to
395aa40
Compare
Now all the format changes are back. |
@cknitt check again. |
* disallow non-variant spreads in variants * changelog * undo formatting in changelog * run make lib * changelog * fix * changelog # Conflicts: # CHANGELOG.md
* disallow non-variant spreads in variants * changelog * undo formatting in changelog * run make lib * changelog * fix * changelog # Conflicts: # CHANGELOG.md
Disallows anything but regular variants as spreads in other variants. Closes #6952.