Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belt: clean up uncurried handling; deprecate xxxU functions #6941

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Aug 7, 2024

As curried mode is gone, it makes no sense to distinguish between "U" (uncurried) and non-"U" (curried) functions anymore in Belt.

This PR makes the following changes:

  • Use non-"U" functions for the actual implementation
  • Internal modules: remove the "U"-functions
  • User-facing modules: define the "U" functions as aliases to the non-"U" functions and mark them as deprecated

The "U" functions can then be fully removed in a future release.

@cknitt cknitt requested a review from cristianoc August 7, 2024 13:37
@cknitt cknitt marked this pull request as ready for review August 7, 2024 13:38
@cknitt cknitt requested a review from zth August 7, 2024 13:38
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work!

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet fix!
It's backwards compatible with existing code right?

@cknitt
Copy link
Member Author

cknitt commented Aug 7, 2024

It's backwards compatible with existing code right?

It should be. I did not intentionally change any logic, and the tests are still running. 🙂

@cknitt cknitt merged commit b90ad1e into rescript-lang:master Aug 7, 2024
20 checks passed
@cknitt cknitt deleted the belt-cleanup branch August 7, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants