Remove caml_external_polyfill and the related behavior (e.g. ?primitive)
#6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometkim
changed the title
?ffi)
cometkim
force-pushed
the
drop-polyfill
branch
2 times, most recently
from
dfa2144 to
b4fcf89
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cometkim
changed the title
?ffi)caml_external_polyfill and the related behavior (e.g. ?primitive)
cristianoc
approved these changes
Jul 31, 2024
cknitt
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the feature introduced from #1361 and #3629
if the external name starts with
?then the compiler injects runtime resolver, which usesglobalThisvery dangerously.The feature is unused and should be replaced by
@scopeor@modulein user code.Further works
There are still many
?-prefixed primitives, but actually specialized and don't accept user polyfill just like other%or#primitives.If we remove caml runtimes, keeping it as a different syntax no longer makes sense IMHO. I'll work on refactoring the primitives in a separate PR.