-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back Js_typed_array #6891
Add back Js_typed_array #6891
Conversation
What about adding back just the types and not the implementations, what do you think about that? |
I'd prefer to to keep backwards compatibility as much as possible. So keeping everything except the externals using |
Cool! |
I kept 100% compatibility, but that requires all that tedious repetitive work from e.g. @send
external copyWithinFrom: (t<'a>, ~to_: int, ~from: int) => 'this = "copyWithin"
let copyWithinFrom = (~to_, ~from, obj) => copyWithinFrom(obj, ~to_, ~from) Copilot and autocomplete help, but it's still tedious. |
@cristianoc @zth Ok to proceed with this PR as is? |
Go for it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a quick line in the changelog describing the situation.
No description provided.