Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove tracking of uncurried state in parser/printer. #6888

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc force-pushed the remove-curried-setting-syntax branch from 626224e to 2ddaf7a Compare July 18, 2024 07:03
@cristianoc cristianoc requested review from cknitt and zth July 18, 2024 07:04
@cristianoc cristianoc force-pushed the remove-curried-setting-syntax branch from 2ddaf7a to a921c2b Compare July 18, 2024 07:05
It used to be required to identify uncurried application.
Now all applications are uncurried, so it is redundant.
@cristianoc cristianoc enabled auto-merge (rebase) July 18, 2024 07:20
@cristianoc cristianoc merged commit bd74e91 into master Jul 18, 2024
18 checks passed
@cristianoc cristianoc deleted the remove-curried-setting-syntax branch July 18, 2024 07:31
@zth
Copy link
Collaborator

zth commented Jul 18, 2024

Won't this be problematic for continuing vendoring the syntax in the editor tooling?

@cristianoc
Copy link
Collaborator Author

Won't this be problematic for continuing vendoring the syntax in the editor tooling?

What use of the parser might be problematic you reckon?

Btw worth thinking again at moving the extension into the compiler now that the release velocity is good. And betas can be created in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants