Ignore -uncurried compiler flag.
#6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
remove-uncurried-flag
branch
3 times, most recently
from
1578c6a to
851fcab
Compare
cristianoc
force-pushed
the
remove-uncurried-flag
branch
from
851fcab to
3bb4545
Compare
zth
approved these changes
Jul 18, 2024
cknitt
reviewed
Jul 18, 2024
| @@ -1,27 +1,26 @@ | |||
| @@jsxConfig({version: 3}) | |||
|
|
|||
| module V3 = { | |||
| @obj external makeProps: (~a: 'a, ~b: 'b, ~key: string=?, unit) => {"a": 'a, "b": 'b} = "" | |||
| @obj external makeProps: (~key: string=?, unit) => {.} = "" | |||
There was a problem hiding this comment.
This change looks weird, why did a and b disappear?
There was a problem hiding this comment.
Good question: @mununki would you open an issue and take a look?
(Issue: typeConstraint.res does not look right in uncurried mode).
| \"TypeConstraint$V3" | ||
| } | ||
| } | ||
|
|
||
| @@jsxConfig({version: 4, mode: "classic"}) | ||
|
|
||
| module V4C = { | ||
| type props<'a, 'b> = {a: 'a, b: 'b} | ||
| type props = {} |
| @@ -226,10 +226,10 @@ let f = ( | |||
| /* c6 */ ~x=?, | |||
| ) => /* c7 */ () | |||
|
|
|||
| let multiply = (type /* c-2 */ t /* c-1 */, /* c0 */ m1 /* c1 */, /* c2 */ m2 /* c3 */) => () | |||
| let multiply = (type /* c-2 */ t /* c-1 */, m1 /* c1 */, /* c2 */ m2 /* c3 */) => () | |||
There was a problem hiding this comment.
Would you open a separate issue about formatting for this example?
Merged
|
Taken note of the observations for creating separate issues. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax tests have changed as they were still run in curried mode.