Fix issues with the arity of externals. #6881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
external_arity_fix
branch
from
51d7b21 to
3d9f800
Compare
cristianoc
force-pushed
the
external_arity_fix
branch
from
3d9f800 to
533e613
Compare
cristianoc
force-pushed
the
external_arity_fix
branch
from
533e613 to
b6810b4
Compare
cknitt
reviewed
Jul 16, 2024
| @@ -4,11 +4,11 @@ import ImportHookDefaultGen from "./ImportHookDefault.gen"; | |||
| import * as ImportHookDefaultGen$1 from "./ImportHookDefault.gen"; | |||
|
|
|||
| function make(prim) { | |||
| return ImportHookDefaultGen$1.make; | |||
| return ImportHookDefaultGen$1.make(prim); | |||
There was a problem hiding this comment.
This change in the output looks incorrect to me.
Before it returned the make function, now it applies it and returns the result.
There was a problem hiding this comment.
It was broken before.
There was a problem hiding this comment.
Ah yes, I missed this in the review of the previous PR. 🙈
cristianoc
force-pushed
the
external_arity_fix
branch
from
b6810b4 to
9ad29cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.