Remove coercion with 2 types, which is only supported in ml syntax. #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
approved these changes
Jun 25, 2024
cristianoc
commented
Jun 25, 2024
jscomp/ml/typedtree.mli
Outdated
| | Texp_coerce of core_type option * core_type | ||
| (** E :> T [Texp_coerce (None, T)] | ||
| E : T0 :> T [Texp_coerce (Some T0, T)] | ||
| | Texp_coerce of core_type |
There was a problem hiding this comment.
Will this be problematic for the editor tooling/other things that read the compiler artifacts?
@zth good question.
This should be Texp_coerce of unit * core_type so for old compiler versions will produce a .cmt that has the rhs core_type in the right place (and the lhs apparing to be None).
There was a problem hiding this comment.
That'll make it work I take it?
There was a problem hiding this comment.
I have no idea how things are represented in OCaml and what can break.
There was a problem hiding this comment.
At runtime unit is 0 just like None, so the new representation will generate files that appear as valid also in the old representation.
There are two forms of type coercion: 1 `e: t0 :> t` 2 `e :> t` The first form was never supported in .res syntax, and is now removed from parsed and typed tree. That said, coercion 1 is the only one that ever supported coercion with free variables. So this is subject to more investigation. See #6828
cristianoc
force-pushed
the
remove_coercion_two_types
branch
2 times, most recently
from
3beb1fa to
0a39286
Compare
By adding a unit argument to the payload.
cristianoc
force-pushed
the
remove_coercion_two_types
branch
from
0a39286 to
8af7d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two forms of type coercion:
1
e: t0 :> t2
e :> tThe first form was never supported in .res syntax, and is now removed from parsed and typed tree.
That said, coercion 1 is the only one that ever supported coercion with free variables. So this is subject to more investigation.
See #6828