Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make j and js allowed names for tag functions #6817

Merged
merged 1 commit into from
Jun 18, 2024
Merged

make j and js allowed names for tag functions #6817

merged 1 commit into from
Jun 18, 2024

Conversation

tsnobip
Copy link
Contributor

@tsnobip tsnobip commented Jun 17, 2024

No description provided.

@tsnobip tsnobip force-pushed the allow_j_js_tagged_templates branch from 1372166 to 8f2e576 Compare June 17, 2024 10:24
@tsnobip tsnobip requested a review from cknitt June 17, 2024 10:26
@cknitt
Copy link
Member

cknitt commented Jun 17, 2024

Nice! Could you remove the inadvertently added jscomp/syntax/temp/files.txt?

@tsnobip tsnobip force-pushed the allow_j_js_tagged_templates branch from 8f2e576 to cf824ce Compare June 17, 2024 13:58
@tsnobip
Copy link
Contributor Author

tsnobip commented Jun 17, 2024

Nice! Could you remove the inadvertently added jscomp/syntax/temp/files.txt?

done @cknitt! I don't know how it got here in the first place, but I guess I just forgot to remove some artefacts from previous fix attempts.

cknitt
cknitt approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @cristianoc ok with you?

@cristianoc
Copy link
Collaborator

LGTM! @cristianoc ok with you?

Looks good to me.
One thing to double check is that normal template literals, without any tags, still work as before.
I guess we would have found out by some tests if they did not, but worth checking just in case.

@tsnobip tsnobip force-pushed the allow_j_js_tagged_templates branch from cf824ce to b10e415 Compare June 18, 2024 08:28
@tsnobip tsnobip force-pushed the allow_j_js_tagged_templates branch from b10e415 to ece78fe Compare June 18, 2024 08:32
@tsnobip
Copy link
Contributor Author

tsnobip commented Jun 18, 2024

One thing to double check is that normal template literals, without any tags, still work as before.
I guess we would have found out by some tests if they did not, but worth checking just in case.

The path for string interpolation was left untouched so it should not have any impact, for the sake of it I still added a a test for regular string interpolation and it's all green.

@tsnobip tsnobip merged commit 74a4bf8 into master Jun 18, 2024
19 checks passed
@tsnobip tsnobip deleted the allow_j_js_tagged_templates branch June 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsnobip @cknitt @cristianoc