Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml 5.2.0 #6797

Merged
merged 1 commit into from
Jun 16, 2024
Merged

OCaml 5.2.0 #6797

merged 1 commit into from
Jun 16, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 30, 2024

No description provided.

@cknitt cknitt force-pushed the ocaml-5.2.0 branch 2 times, most recently from edd03d7 to baafe53 Compare May 30, 2024 17:19
@cknitt cknitt marked this pull request as draft May 30, 2024 17:30
@cknitt
Copy link
Member Author

cknitt commented May 30, 2024

Unfortunately Windows does not work yet:

The following dependencies couldn't be met:
  - rescript -> ocamlformat >= 0.26.2 -> ocamlformat-lib >= 0.26.2 -> fpath -> ocamlbuild -> base-ocamlbuild -> ocaml < 4.03
      base of this switch (use `--unlock-base' to force)
  - rescript -> ocamlformat >= 0.[26](https://github.com/rescript-lang/rescript-compiler/actions/runs/9306607422/job/25616305621?pr=6797#step:10:27).2 -> ocamlformat-lib >= 0.26.2 -> fpath -> ocamlbuild -> ocaml < 5.2
      base of this switch (use `--unlock-base' to force)
  - rescript -> ocamlformat >= 0.26.2 -> ocamlformat-lib >= 0.26.2 -> fpath -> ocaml < 4.12
      base of this switch (use `--unlock-base' to force)

@cknitt cknitt marked this pull request as ready for review June 16, 2024 06:23
@cknitt
Copy link
Member Author

cknitt commented Jun 16, 2024

Works now!

@cknitt cknitt requested review from cristianoc and zth June 16, 2024 06:23
cristianoc
cristianoc approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that it still builds locally on older compiler versions.
Seems fine, and only require an update of ocamlformat.

@cknitt cknitt merged commit d2604ad into rescript-lang:master Jun 16, 2024
19 checks passed
@cknitt cknitt deleted the ocaml-5.2.0 branch June 16, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@zth zth Awaiting requested review from zth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc