PPX v4: mark props type in externals as @live.
#6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rescript-lang/rescript-vscode#994 Dead code elimination in the editor tooling complains about props never being read in the `props` type record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This OR marks the `props` type definition as `@live` for external components, so the dead code analysis does not fire.
cristianoc
force-pushed
the
prop-type-externals-live
branch
from
fc2e2c8 to
05c1cc1
Compare
|
Incidentally, noticed there were no PPX v4 tests for external components in interface files. Added one in |
mununki
approved these changes
May 31, 2024
| @@ -346,22 +346,26 @@ let make_type_decls_with_core_type props_name loc core_type typ_vars = | |||
| ~manifest:core_type; | |||
| ] | |||
|
|
|||
| let live_attr = ({txt = "live"; loc = Location.none}, PStr []) | |||
There was a problem hiding this comment.
nit: Maybe we can put this in jsx_common.ml like Jsx_common.optionalAttr
cknitt
pushed a commit
that referenced
this pull request
Jun 15, 2024
* PPX v4: mark props type in externals as `@live`. Fixes rescript-lang/rescript-vscode#994 Dead code elimination in the editor tooling complains about props never being read in the `props` type record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This OR marks the `props` type definition as `@live` for external components, so the dead code analysis does not fire. * Update CHANGELOG.md
cknitt
pushed a commit
that referenced
this pull request
Jun 16, 2024
* PPX v4: mark props type in externals as `@live`. Fixes rescript-lang/rescript-vscode#994 Dead code elimination in the editor tooling complains about props never being read in the `props` type record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This OR marks the `props` type definition as `@live` for external components, so the dead code analysis does not fire. * Update CHANGELOG.md
cknitt
pushed a commit
that referenced
this pull request
Jun 16, 2024
* PPX v4: mark props type in externals as `@live`. Fixes rescript-lang/rescript-vscode#994 Dead code elimination in the editor tooling complains about props never being read in the `props` type record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This OR marks the `props` type definition as `@live` for external components, so the dead code analysis does not fire. * Update CHANGELOG.md
cknitt
pushed a commit
that referenced
this pull request
Jun 16, 2024
* PPX v4: mark props type in externals as `@live`. Fixes rescript-lang/rescript-vscode#994 Dead code elimination in the editor tooling complains about props never being read in the `props` type record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This OR marks the `props` type definition as `@live` for external components, so the dead code analysis does not fire. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rescript-lang/rescript-vscode#994
Dead code elimination in the editor tooling complains about props never being read in the
propstype record defined by the V4 ppx. This is because externals don't provide the implementation of the component, and it's in the implementation that props could be read. This PR marks thepropstype definition as@livefor external components, so the dead code analysis does not complain.