Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphen_jsx_attribute #6705

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Hyphen_jsx_attribute #6705

merged 1 commit into from
Apr 4, 2024

Conversation

tsnobip
Copy link
Contributor

@tsnobip tsnobip commented Apr 2, 2024

Since the parser already supported hyphens in prop names, I updated the printer to support it too, I guess it's more coherent.

@tsnobip tsnobip marked this pull request as ready for review April 2, 2024 09:00
@tsnobip tsnobip force-pushed the hyphen_jsx_attribute branch from 6eaa6a9 to e828904 Compare April 2, 2024 09:01
@tsnobip tsnobip requested a review from fhammerschmidt April 2, 2024 09:02
@fhammerschmidt fhammerschmidt requested review from cknitt and zth April 2, 2024 11:13
CHANGELOG.md Outdated Show resolved Hide resolved
@tsnobip tsnobip force-pushed the hyphen_jsx_attribute branch from e828904 to ced220c Compare April 2, 2024 14:01
@tsnobip tsnobip requested a review from cknitt April 2, 2024 14:02
@tsnobip tsnobip force-pushed the hyphen_jsx_attribute branch from 1cdc5e4 to 71ce5b0 Compare April 4, 2024 08:31
@fhammerschmidt
Copy link
Member

ok let's merge this
just move the changelog entry up one version and we are good to go

@tsnobip tsnobip force-pushed the hyphen_jsx_attribute branch from 71ce5b0 to 2193015 Compare April 4, 2024 10:53
@tsnobip tsnobip force-pushed the hyphen_jsx_attribute branch from 2193015 to 62428aa Compare April 4, 2024 10:54
@tsnobip tsnobip enabled auto-merge (rebase) April 4, 2024 10:54
@tsnobip tsnobip merged commit 1ec144b into 11.0_release Apr 4, 2024
14 checks passed
@zth zth deleted the hyphen_jsx_attribute branch April 4, 2024 11:20
tsnobip added a commit that referenced this pull request Apr 18, 2024
fhammerschmidt pushed a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants