Fix local type variables breaking react components in uncurried mode #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* omit trailing undefined in external function calls * changelog * changelog
mununki
reviewed
Mar 4, 2024
jscomp/syntax/src/jsx_common.ml
Outdated
Comment on lines
61
to
65
| | Pexp_newtype (label, e) -> | ||
| { | ||
| expr with | ||
| pexp_desc = Pexp_newtype (label, removeArityRecord e); | ||
| } |
There was a problem hiding this comment.
I guess this would fix the issue, thanks!
|
This should probably be ported to v11 too. It can make it into the v11.1 release. |
…escript-lang#6664) * add test * fix dynamic import of external * add test for adding static import * add change log
|
@glennsl actually, would you mind rebasing onto the v11_release branch? |
…#6656) * make the partial match suggestion easier to copy * add changelog
glennsl
force-pushed
the
fix/uncurried/react-component-newtype
branch
from
457df73 to
1a7e08b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6625