Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dict as a builtin #6590

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Dict as a builtin #6590

merged 5 commits into from
Jan 30, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 30, 2024

This sets dict up as a builtin type. Preparation for first classing dicts:

  1. Optimize creation so it can compile to a clean instantiation of a JS object Specialize uses of new dict literal to direct JS object creation #6538
  2. Dedicated syntax with spread support and more [RFC] Dedicated syntax for creating Dicts #6545

@cristianoc is this on the right track? See any immediate issues?

@zth zth requested a review from cristianoc January 30, 2024 09:07
@zth zth mentioned this pull request Jan 30, 2024
Closed
@zth zth enabled auto-merge (squash) January 30, 2024 09:18
@zth zth merged commit d206b2d into 11.0_release Jan 30, 2024
14 checks passed
@zth zth deleted the dict-builtin branch April 2, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc