correctly print exotic JSX names #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
approved these changes
Oct 25, 2023
| @@ -6,13 +6,17 @@ let x = <Foo.bar className="container" /> | |||
| let x = <Foo.baz | |||
| className="multiline" | |||
| /> | |||
| let x = <\"custom-tag" className="container" /> | |||
There was a problem hiding this comment.
Side note, but given that this looks like a close tag (but is not), are there other issues this could cause? How can we test those?
There was a problem hiding this comment.
yes readability suffers a bit with this, maybe we could change the parser to make it accept exotic names inside double quotes without escaping them with a \, like polymorphic variants, but this would be more work for something that is definitely a corner case.
There was a problem hiding this comment.
Probably will be easier to make <my-custom-tag className="hello" /> compile in the case
|
Looks good to me. |
|
@tsnobip can you add an entry to the changelog? Then we're good to go. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this fix,
would get reformatted to:
which doesn't compile.