Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve aliases in untagged variants types #6394

Merged
merged 2 commits into from
Sep 8, 2023
Merged

resolve aliases in untagged variants types #6394

merged 2 commits into from
Sep 8, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 7, 2023

Closes #6388

@zth zth requested a review from cristianoc September 7, 2023 19:15
@zth zth mentioned this pull request Sep 7, 2023
Closed
@DZakh
Copy link
Contributor

DZakh commented Sep 7, 2023

I wonder whether this issue will also be solved #6327
A test would be nice

@zth
Copy link
Collaborator Author

zth commented Sep 7, 2023

I tried it, and unfortunately it doesn't seem to fix that. Must be some other issue.

cristianoc
cristianoc approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR expands heads.

@zth zth merged commit e7d4868 into master Sep 8, 2023
@zth zth deleted the untagged-variants-resolve-aliases branch September 8, 2023 04:28
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use Dict.t<json>
3 participants
@zth @DZakh @cristianoc