Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate comments from record fields to gentype output #6333

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Propagate comments from record fields to gentype output #6333

merged 2 commits into from
Jul 27, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Jul 27, 2023 •
edited
Loading

This propagates comments from record fields to the corresponding fields in the printed TS type declarations.

Fixes part of issues raised in #6332

@zth zth requested a review from cristianoc July 27, 2023 06:58
cristianoc
cristianoc approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@zth zth merged commit 43e1175 into master Jul 27, 2023
@zth zth deleted the gentype-comments branch July 27, 2023 07:57
@zth zth mentioned this pull request Jul 27, 2023
Closed
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc