-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make uncurried mode opt-out. #6249
Conversation
By default, every project is in uncurried mode, unless `"uncurried": false` is specified in the project config.
b9dbf87
to
10ad220
Compare
Hi @cristianoc, I was experimenting with 11.0.0-alpha.3 lately in one of my smaller projects. Since I use curried functions a lot; I added To make a case, let's use
that exploit the curried. So, I added
I this case the library This example is just a showcase. In this particular instance, it's easy to even remove the dependency completely. But this example also shows that other projects would have to wait till I guess I'm too late for this party; but you might want to reconsider the default. It might have a major impact in the adoption of Rescript 11. I certainly want to upgrade. The other features are very compelling. But this one change would prevent me to switch because the dependencies are not ready. |
Note: compiling |
Can you confirm:
Then the dependencies are compiled with uncurried mode active? |
Hi @cristianoc, Thanks for your response. Indeed it works after cleaning up. Sorry, I didn't try that before bringing this up. |
By default, every project is in uncurried mode, unless
"uncurried": false
is specified in the project config.