-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit directive above header comment (v11) #6172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
It looks like the test we have directive.res
is not affected probably just because of how the compilation of tests happens, without generating header comments.
Indeed this is from
Some tests change the bsc flags locally in the file. Let me look up how that's done. |
Here's an example: @@config({flags: ["-bs-gentype"]})
|
One could in principle go here: "-bs-no-version-header", set Js_config.no_version_header,
"*internal*Don't print version header"; and add an option to turn it back on. |
Happy to merge as-is, or if you'd like to change something in the tests just lmk. |
I can remove the |
That sounds good to me. No reason why test file should look different from normal compiled files. |
@@ -1,5 +1,6 @@ | |||
first directive; | |||
second directive; | |||
// Generated by ReScript, PLEASE EDIT WITH CARE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Close #6170