Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS reserved keywords list, clean up scripts, add documentation #6167

Merged
merged 6 commits into from
Apr 16, 2023
Merged

Update JS reserved keywords list, clean up scripts, add documentation #6167

merged 6 commits into from
Apr 16, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Apr 16, 2023 •
edited
Loading

The compiler sources include a list of reserved JS keywords in jscomp/ext/js_reserved_map.ml which includes all identifiers in global scope (window).

Clean up scripts, update this list and add documentation.

@cknitt cknitt requested a review from cristianoc April 16, 2023 07:44
@cknitt cknitt merged commit 5d948c4 into rescript-lang:master Apr 16, 2023
@cknitt cknitt deleted the keywords branch April 16, 2023 09:01
@anmonteiro anmonteiro mentioned this pull request May 7, 2023
Merged
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc