Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make components actually uncurried functions in uncurried mode. #6087

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

cristianoc
Copy link
Collaborator

This change does not seem strictly necessary, and it's a bit invasive. E.g. the editor integration needs to be adapted.
But eventually, we'll want this in, as otherwise e.g. hover on the make would show a curried function.

Subtyping from uncurried to curried functions was not working when the expected curried function was under a type definition.
This would give type errors on components that take a component type as prop.
This change does not seem strictly necessary, and it's a bit invasive.
E.g. the editor integration needs to be adapted.
But eventually, we'll want this in, as otherwise e.g. hover on the `make` would show a curried function.
Base automatically changed from subtype_uncurried to master March 20, 2023 10:49
@cristianoc cristianoc merged commit c8b2585 into master Mar 20, 2023
@cristianoc cristianoc deleted the uncurried_jsx_functions branch March 20, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant