Fix issue with comparison of string constants #6065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String constants were compare literally, as part of constant propagation. This means that for example `"\a" == "a"` was compiled to `false` even though the two represent the same strings. Unicode and hex escape codes are other examples where literal comparison is not correct. Implemented a 3-way string comparison: equality returns Some(true), Some(false), or None where the result is not determined.
cristianoc
force-pushed
the
string_constants_compare_v10
branch
from
c358ef8 to
fdee54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String constants were compare literally, as part of constant propagation. This means that for example
"\a" == "a"was compiled tofalseeven though the two represent the same strings. Unicode and hex escape codes are other examples where literal comparison is not correct.Implemented a 3-way string comparison: equality returns Some(true), Some(false), or None where the result is not determined.