@cknitt this should go into branch 10.1 ?

Right, we need that in 10.1, too.
And on master there is a Windows CI issue when the syntax has changed, will look into that.

Need to rebase to 10.1_release?

@mununki Yes, please, that would be great (but for 10.1 the change needs to be made in the syntax repo).

@mununki Yes, please, that would be great (but for 10.1 the change needs to be made in the syntax repo).

Not clear to me. Do I need to make another PR in the syntax repo? I thought the syntax repo was archived.

Yes, you would need to make another PR in the syntax repo first, as the 10.1 release branch still has the syntax submodule.

Yes, you would need to make another PR in the syntax repo first, as the 10.1 release branch still has the syntax submodule.

Ah! I got it, remember that.

I made another PR in the syntax repo rescript-lang/syntax#720

@cknitt still does this branch need to be rebased to 10.1_release?

You would need to create a new PR for the 10.1_release branch that uses the updated syntax (once your syntax PR is merged).

You would need to create a new PR for the 10.1_release branch that uses the updated syntax (once your syntax PR is merged).

If so, then I'm going to close this PR.

Well, we still need the fix on master, too. :-)

Ooops, I reopen it 😄

The updating change log seems already done in #5884 (comment). If this PR doesn't need to update the change log in the compiler, let me know.

Please rebase to latest master, the Windows build should work now.

Please rebase to latest master, the Windows build should work now.

Thanks. Rebased to master.