Fix char pattern matching in unicode #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for the other PR to change the payload of Const_char first. |
Merged
|
@butterunderflow the char change is landed, can you do a rebase/cleanup to make this fix available? thanks! |
cristianoc
reviewed
Oct 31, 2022
CHANGELOG.md
Outdated
| @@ -56,6 +56,7 @@ | |||
|
|
|||
| - Add `loading`, `aria-*` DOM element attributes in `JsxDOM.domProps`: `ariaCurrent`, `ariaInvalid`, `ariaAutocomplete`, etc. | |||
| - Change the internal representation of props for the lowercase components to record. https://github.com/rescript-lang/syntax/pull/665 | |||
| - Change the payload of Pconst_char for type safety. https://github.com/rescript-lang/syntax/pull/709 | |||
There was a problem hiding this comment.
This PR should be rebases on the latest version of branch 10.1_release then moved to the section # 10.1.0-rc.3.
cristianoc
reviewed
Oct 31, 2022
Closed
* change Pconst_char payload (WIP) * tweak * tweak * representation of char for lambda * lib * bugfix: replace wrong pp * libs * bugfix: replace wrong print * use unsafe_chr to handle possible overflow char * safe print int as char * reduce duplication * (re)use encodeCodepoint to support string_of_int_as_char * some refactor * libs * changelog
bobzhang
force-pushed
the
fix_char_pattern
branch
from
6adc517 to
be27cab
Compare
|
@butterunderflow in 7d15ea8 I adjusted string_of_int_as_char a little bit to avoid regressions |
cristianoc
approved these changes
Oct 31, 2022
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix, need some clean up
Things to do: change
Pconst_char chartoPconst_char intto avoid unneeded Obj.magicRes_printer for pattern needs adapting to print
Pconst_char 0which is generated by the compilercc @butterunderflow