Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate jsx config to dependencies, and add config "preserve-dependencies". #5661

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

cristianoc
Copy link
Collaborator

No description provided.

@cristianoc cristianoc requested a review from cknitt September 13, 2022 11:47
Example:
```
  "jsx": { "version": 4, "exclude-dependencies": ["rescript-react-navigation"] }
```
@cristianoc cristianoc changed the title Test: propagate jsx config to dependencies. Propagate jsx config to dependencies, and add config "exclude-dependencies". Sep 15, 2022
@cristianoc cristianoc requested a review from cknitt September 15, 2022 10:26
@cristianoc
Copy link
Collaborator Author

@cknitt would you review the latest changes.

@cknitt
Copy link
Member

cknitt commented Sep 15, 2022

LGTM, just a bit unsure about the naming of exclude-dependencies. Might sound like they were excluded from JSX transformation altogether. Haven't really had a better idea though - no-propagate-to? no-override-deps?? 🤔

@cristianoc cristianoc changed the title Propagate jsx config to dependencies, and add config "exclude-dependencies". Propagate jsx config to dependencies, and add config "preserve-dependencies". Sep 15, 2022
@cristianoc cristianoc merged commit ef3420e into master Sep 15, 2022
@cristianoc cristianoc deleted the propagate_jsx_config branch September 15, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants