Fix issue with arrays and creation of recursive values. #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not clear where the reference to ocaml/ocaml#6939 comes from, as that issue is about unboxed float arrays. See https://forum.rescript-lang.org/t/recursive-type-usage-problem/3717
cristianoc
commented
Sep 7, 2022
| @@ -236,10 +236,7 @@ let rec expression : Env.env -> Typedtree.expression -> Use.t = | |||
| let arg env (_, eo) = option expression env eo in | |||
| Use.(join (inspect (expression env e)) (inspect (list arg env args))) | |||
| | Texp_tuple exprs -> Use.guard (list expression env exprs) | |||
| | Texp_array exprs -> | |||
There was a problem hiding this comment.
This line seems to be coming from here: 0f3d69a
but it's unclear where it's coming from
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not clear where the reference to ocaml/ocaml#6939 comes from, as that issue is about unboxed float arrays.
See https://forum.rescript-lang.org/t/recursive-type-usage-problem/3717