Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further fix for %bytes_to_string #5589

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Further fix for %bytes_to_string #5589

merged 1 commit into from
Jul 24, 2022

Conversation

TheSpyder
Copy link
Contributor

PR #5580 didn't use the correct reference; my initial suggestion was to use unsafe_to_string but that's just the same as to_string now.

Fixes #5573

cristianoc
cristianoc approved these changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I will update the changelog.

@cristianoc cristianoc merged commit 45c8b91 into rescript-lang:master Jul 24, 2022
@TheSpyder TheSpyder deleted the bytes_to_string branch July 24, 2022 06:27
@TheSpyder
Copy link
Contributor Author

Ah I didn’t think it needed a changelog because it was an updated version of an existing fix, but yeah I see now it’s a change since the last RC

@cristianoc
Copy link
Collaborator

I've added it just as a reminder of "we might need another release" or "thing is going into the final release"

@cristianoc cristianoc mentioned this pull request Sep 20, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bytes_to_string is missing
2 participants
@TheSpyder @cristianoc