Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async await support #5537

Merged
merged 51 commits into from
Jul 18, 2022
Merged

Async await support #5537

merged 51 commits into from
Jul 18, 2022

Conversation

cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Jul 11, 2022 •
edited
Loading

Add support for async/await.
This was taken from cristianoc/rescript-compiler-experiments#1

  • questions on best way to implement the type check for nested promises
  • surface syntax from the syntax repo
  • tests
  • docs

cristianoc
cristianoc commented Jul 11, 2022
View reviewed changes
jscomp/core/j.ml Outdated Show resolved Hide resolved
jscomp/frontend/ast_uncurry_gen.mli Show resolved Hide resolved
jscomp/ml/translcore.ml Outdated Show resolved Hide resolved
jscomp/ml/typecore.ml
@@ -1864,7 +1864,34 @@ and type_expect ?in_function ?recarg env sexp ty_expected =
type_expect_ ?in_function ?recarg env sexp ty_expected
)
in
Cmt_format.set_saved_types
let () =
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the best place to perform this check? Performance?

jscomp/others/js_promise.ml Outdated Show resolved Hide resolved
jscomp/others/js_promise.ml Outdated Show resolved Hide resolved
@cristianoc cristianoc added this to the v10.1 milestone Jul 11, 2022
cristianoc added 28 commits July 18, 2022 10:05
@cristianoc
Experiment with async-await.
0b07581
@cristianoc
Add example project example-async.
0270e9c
@cristianoc
Use @async attribute instead of an external.
1c501d0
@cristianoc
Remove old support for async primitive.
8ccd6fa
@cristianoc
Add recursive function to run all tests.
e2dc279
@cristianoc
Support for @await decorator.
1e3c8a8
@cristianoc
Support async callbacks.
9e4f143
@cristianoc
tweak callback example
804a40f
@cristianoc
Add async list example.
c11c3ca
@cristianoc
Clean up treatment of async attribute.
64c0057
@cristianoc
Work around funny pretty printer formatting of await.
d3ce0a8
@cristianoc
Clean up.
1d55824
@cristianoc
clean up dump
cb1568c
@cristianoc
format dump
813d98e
@cristianoc
More cleanup.
b98bc9a
@cristianoc
Give error when awaiting not in an async context.
ee80cf6
@cristianoc
Give error when async is applied to a curried function.
cc05e6e
@cristianoc
Less invasive change to the ppx.
bf7fe9c
@cristianoc
More ppx cleanup.
7384191
@cristianoc
Use dedicated ast functions.
42db790
@cristianoc
Add module Ast_await.
3d1d2e6
@cristianoc
Lift restriction to uncurried functions.
af913a4 
Use the existing convention in the printer to determine a conventional meaning to the result.
`x => y => 3` is formatted as `(x,y) => 3`
so `@async x => y => 3` adds a promise to the result `3`.
@cristianoc
Braces are preserved by reformatting, but belong to the same function.
ab2cbec
@cristianoc
Unusual uncurried function with 2 arguments.
f8bb32d
@cristianoc
Use .mjs in source dir.
60809c5
@cristianoc
Add example fetch using result type.
b3bb5e6
@cristianoc
Add imaginary syntax.
6ad7eb7
@cristianoc
tweak imaginary syntax, free up "&&".
2811546
cristianoc added 19 commits July 18, 2022 10:05
@cristianoc
"and" seems more idiomatic
2febc63
@cristianoc
Example with exception-annotated fetch.
7358623
@cristianoc
tweak example
dc257ce
@cristianoc
snapshot
9456dfd
@cristianoc
Rebase on latest 10.0 alpha compiler.
1aedc89
@cristianoc
Begin preparing for source syntax.
412e390 
See rescript-lang/syntax#600
@cristianoc
Pull in the surface syntax from the syntax submodule.
815568e 
Pull in rescript-lang/syntax#600
@cristianoc
Make sure the example still builds.
a3bc904
@cristianoc
Example: switch to the new res.* attributes.
e00ef8b
@cristianoc
Example: switch async to surface syntax.
00ea266
@cristianoc
Switch over await's to surface syntax.
58f6857
@cristianoc
Sync latest surface syntax.
1fe1149
@cristianoc
Almost reformat.
57758b1
@cristianoc
One more syntax sync.
2420fd1
@cristianoc
Update .prettierignore
6b0ed47
@cristianoc
Rebase on latest compiler.
0c318fb
@cristianoc
remove example from experiments repo
ea05f76
@cristianoc
Update .prettierignore
8cd6abe
@cristianoc
rebase on master and use latest syntax
8a38fb4
@cristianoc cristianoc force-pushed the async-await-support branch from 5210e3c to 8a38fb4 Compare July 18, 2022 08:10
@cristianoc cristianoc mentioned this pull request Jul 18, 2022
Closed
@cristianoc cristianoc merged commit b30d6dd into master Jul 18, 2022
@cristianoc cristianoc deleted the async-await-support branch July 18, 2022 09:03
@cristianoc cristianoc mentioned this pull request Sep 27, 2022
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.1
Development

Successfully merging this pull request may close these issues.
1 participant
@cristianoc