Skip to content

Introduce inputModes option for showing score and comment fields #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laander wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Introduce inputModes option for showing score and comment fields #472

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
813522d
quick fix with new prop for not requiring satisfaction score
laander Jun 5, 2025
ab464b6
Merge branch 'main' into buc-3227-dogfooding-dont-require-satisfactio…
laander Sep 9, 2025
d12e742
Merge branch 'main' into buc-3227-dogfooding-dont-require-satisfactio…
laander Sep 9, 2025
cd66efc
total overhaul with new inputMode option
laander Sep 9, 2025
7096699
update docs with inputMode option
laander Sep 10, 2025
4bc9e1f
update docs with new screenshots and devsever page
laander Sep 10, 2025
ebc3bee
re-rexport OnSubmitResult
laander Sep 10, 2025
f1318f6
Merge branch 'main' into buc-3227-dogfooding-dont-require-satisfactio…
laander Sep 10, 2025
e7ab8d8
add tests for inputMode
laander Sep 10, 2025
b1ad633
update assets
laander Sep 10, 2025
a27328c
Merge branch 'buc-3227-dogfooding-dont-require-satisfaction-score-whe…
laander Sep 10, 2025
4d0b799
fix tests
laander Sep 10, 2025
9c6faae
cleanup and fix tests
laander Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into buc-3227-dogfooding-dont-require-satisfactio… 
…n-score-when-asking-for
  • Loading branch information
@laander
laander committed Sep 9, 2025
commit ab464b6d296205e34ce0dfa24cde8bb3824207dd
2 changes: 1 addition & 1 deletion packages/browser-sdk/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</style>
<div id="start-huddle" style="display: none">
<button
onClick="bucket.requestFeedback({featureKey, requireSatisfactionScore: false, position: {type: 'POPOVER', anchor: event.currentTarget}})"
onClick="bucket.requestFeedback({flagKey, requireSatisfactionScore: false, position: {type: 'POPOVER', anchor: event.currentTarget}})"
>
Give feedback!
</button>
Expand Down
15 changes: 5 additions & 10 deletions packages/browser-sdk/src/feedback/ui/FeedbackForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const ANIMATION_SPEED = 400;

function getFeedbackDataFromForm(el: HTMLFormElement) {
const formData = new FormData(el);
console.log("comment", (formData.get("comment")?.toString() || "").trim());
return {
score: Number(formData.get("score")?.toString()),
comment: (formData.get("comment")?.toString() || "").trim(),
Expand Down Expand Up @@ -67,11 +66,9 @@ export const FeedbackForm: FunctionComponent<FeedbackFormProps> = ({
// Validation logic
if (requireSatisfactionScore) {
if (!data.score) return;
} else {
if (!data.comment) {
setError("Comment is required");
return;
}
} else if (!data.comment) {
setError("Comment is required");
return;
}
setError("");
try {
Expand All @@ -96,8 +93,6 @@ export const FeedbackForm: FunctionComponent<FeedbackFormProps> = ({
const expandedContentRef = useRef<HTMLDivElement>(null);
const submittedRef = useRef<HTMLDivElement>(null);

console.log("formRef", formRef.current);

const transitionToDefault = useCallback(() => {
if (containerRef.current === null) return;
if (headerRef.current === null) return;
Expand Down Expand Up @@ -181,7 +176,7 @@ export const FeedbackForm: FunctionComponent<FeedbackFormProps> = ({
onFocusCapture={onInteraction}
onSubmit={handleSubmit}
>
<div class="title" id="bucket-feedback-score-label">
<div class="title" id="reflag-feedback-score-label">
{question}
</div>
<div ref={expandedContentRef} class="form-expanded-content">
Expand All @@ -196,7 +191,7 @@ export const FeedbackForm: FunctionComponent<FeedbackFormProps> = ({
</div>
<div
ref={headerRef}
aria-labelledby="bucket-feedback-score-label"
aria-labelledby="reflag-feedback-score-label"
class="form-control"
role="group"
>
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.