Skip to content

fix(browser-sdk): remove featureDefinition list #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncohen merged 2 commits into from
Feb 13, 2025
Merged

fix(browser-sdk): remove featureDefinition list #323

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fafbd84
fix(browser-sdk): remove featureDefinition list
roncohen Feb 13, 2025
c1388bd
Merge branch 'browser-react-3.0.alpha' into cleanup-feature-list
roncohen Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(browser-sdk): remove featureDefinition list
  • Loading branch information
@roncohen
roncohen committed Feb 13, 2025
commit fafbd842fcd7031b34720abffe33abc53519f4d0
9 changes: 1 addition & 8 deletions packages/browser-sdk/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,6 @@ export type InitOptions = {
* Toolbar configuration
*/
toolbar?: ToolbarOptions;

/**
* Local-first definition of features.
*/
features?: FeatureDefinitions;
};

const defaultConfig: Config = {
Expand Down Expand Up @@ -342,9 +337,7 @@ function shouldShowToolbar(opts: InitOptions) {
if (typeof toolbarOpts === "boolean") return toolbarOpts;
if (typeof toolbarOpts?.show === "boolean") return toolbarOpts.show;

return (
opts.features !== undefined && window?.location?.hostname === "localhost"
);
return window?.location?.hostname === "localhost";
}

/**
Expand Down