Skip to content

Conversation

@roncohen
Copy link
Contributor

@roncohen roncohen commented Feb 3, 2025

Since main has gone to 1.6-alpha, we need to start a separate branch for 1.5 series releases. This'll let us run the publish script from any branch that starts with v as in v1.5.

@roncohen roncohen requested a review from pavkam February 3, 2025 20:26
@roncohen roncohen enabled auto-merge (squash) February 3, 2025 20:37
@roncohen roncohen changed the title chore: allow publishing of non main branches` chore: allow publishing of "v*" branches Feb 3, 2025
@roncohen roncohen changed the title chore: allow publishing of "v*" branches chore: auto-publish in "v*" branches Feb 3, 2025
@pavkam
Copy link
Contributor

pavkam commented Feb 3, 2025

Should we consider using tags for realses?

@roncohen roncohen merged commit eca331d into main Feb 4, 2025
5 checks passed
@roncohen roncohen deleted the publish-any-v-asterisk-branch branch February 4, 2025 08:20
@roncohen
Copy link
Contributor Author

roncohen commented Feb 4, 2025

Should we consider using tags for realses?

definitely! And I now realize this branching strategy isn't going to work because each package is independently versioned.

@laander
Copy link
Contributor

laander commented Feb 4, 2025

hmm, come to think of it, we can't really talk about the whole repo being at a specific version since it's separate packages e.g. react-sdk is at v3.0.0 -alpha and node-sdk is at v1.6.0-alpha..

branch names could start with a version, like v1.5 but should include the SDK in question to reduce confusion, like v1.5-node-sdk

this branch for example is too generic / unspecific

EDIT: just saw your comment above @roncohen after submitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants