Merge branch 'node-sdk-feature-definitions' of github.com:bucketco/bucket-javascript-sdk into node-sdk-feature-definitions

roncohen · roncohen · commit cd9c6c1db494 · 2025-03-25T20:07:46.000+01:00
diff --git a/packages/node-sdk/README.md b/packages/node-sdk/README.md
@@ -10,16 +10,13 @@ Install using `yarn` or `npm` with:
 
 > `yarn add -s @bucketco/node-sdk` or `npm install -s @bucketco/node-sdk`.
 
-Other supported languages/frameworks are in the
-[Supported languages](https://docs.bucket.co/quickstart/supported-languages)
-documentation pages.
+Other supported languages/frameworks are in the [Supported languages](https://docs.bucket.co/quickstart/supported-languages) documentation pages.
 
-You can also [use the HTTP API directly](https://docs.bucket.co/reference/http-tracking-api)
+You can also [use the HTTP API directly](https://docs.bucket.co/api/http-api)
 
 ## Basic usage
 
-To get started you need to obtain your secret key from the
-[environment settings](https://app.bucket.co/envs/current/settings/app-environments)
+To get started you need to obtain your secret key from the [environment settings](https://app.bucket.co/envs/current/settings/app-environments)
 in Bucket.
 
 > [!CAUTION]
@@ -138,8 +135,8 @@ await client.flush();
 
 ### Rate Limiting
 
-The SDK includes automatic rate limiting for feature events to prevent overwhelming the API. Rate limiting is applied per
-unique combination of feature key and context. The rate limiter window size is configurable:
+The SDK includes automatic rate limiting for feature events to prevent overwhelming the API.
+Rate limiting is applied per unique combination of feature key and context. The rate limiter window size is configurable:
 
 ```typescript
 const client = new BucketClient({
diff --git a/packages/node-sdk/src/utils.ts b/packages/node-sdk/src/utils.ts
@@ -160,7 +160,7 @@ export function hashObject(obj: Record<string, any>): string {
   const hash = createHash("sha1");
   updateSha1Hash(hash, obj);
 
-  return hash.digest("hex");
+  return hash.digest("base64");
 }
 
 export function once<T extends () => ReturnType<T>>(
diff --git a/packages/node-sdk/test/client.test.ts b/packages/node-sdk/test/client.test.ts
@@ -1598,9 +1598,7 @@ describe("BucketClient", () => {
       await client.initialize();
       client.getFeatures({ user, company, other: otherContext });
 
-      expect(isAllowedSpy).toHaveBeenCalledWith(
-        "d461e93fe41f6297ab43402d0fc6d63e2444e07d",
-      );
+      expect(isAllowedSpy).toHaveBeenCalledWith("1GHpP+QfYperQ0AtD8bWPiRE4H0=");
     });
 
     it("should return evaluated features when only user is defined", async () => {
diff --git a/packages/node-sdk/test/utils.test.ts b/packages/node-sdk/test/utils.test.ts
@@ -167,7 +167,7 @@ describe("hashObject", () => {
     expectedHash.update("name");
     expectedHash.update("Alice");
 
-    expect(hash).toBe(expectedHash.digest("hex"));
+    expect(hash).toBe(expectedHash.digest("base64"));
   });
 
   it("should hash arrays within objects", () => {
@@ -180,7 +180,7 @@ describe("hashObject", () => {
     expectedHash.update("2");
     expectedHash.update("3");
 
-    expect(hash).toBe(expectedHash.digest("hex"));
+    expect(hash).toBe(expectedHash.digest("base64"));
   });
 });
 
diff --git a/yarn.lock b/yarn.lock
@@ -69,6 +69,17 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@babel/code-frame@npm:^7.26.2":
+  version: 7.26.2
+  resolution: "@babel/code-frame@npm:7.26.2"
+  dependencies:
+    "@babel/helper-validator-identifier": "npm:^7.25.9"
+    js-tokens: "npm:^4.0.0"
+    picocolors: "npm:^1.0.0"
+  checksum: 10c0/7d79621a6849183c415486af99b1a20b84737e8c11cd55b6544f688c51ce1fd710e6d869c3dd21232023da272a79b91efb3e83b5bc2dc65c1187c5fcd1b72ea8
+  languageName: node
+  linkType: hard
+
 "@babel/compat-data@npm:^7.24.7":
   version: 7.24.7
   resolution: "@babel/compat-data@npm:7.24.7"
@@ -260,12 +271,12 @@ __metadata:
   linkType: hard
 
 "@babel/helpers@npm:^7.24.7":
-  version: 7.24.7
-  resolution: "@babel/helpers@npm:7.24.7"
+  version: 7.26.10
+  resolution: "@babel/helpers@npm:7.26.10"
   dependencies:
-    "@babel/template": "npm:^7.24.7"
-    "@babel/types": "npm:^7.24.7"
-  checksum: 10c0/aa8e230f6668773e17e141dbcab63e935c514b4b0bf1fed04d2eaefda17df68e16b61a56573f7f1d4d1e605ce6cc162b5f7e9fdf159fde1fd9b77c920ae47d27
+    "@babel/template": "npm:^7.26.9"
+    "@babel/types": "npm:^7.26.10"
+  checksum: 10c0/f99e1836bcffce96db43158518bb4a24cf266820021f6461092a776cba2dc01d9fc8b1b90979d7643c5c2ab7facc438149064463a52dd528b21c6ab32509784f
   languageName: node
   linkType: hard
 
@@ -333,12 +344,23 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@babel/parser@npm:^7.26.9":
+  version: 7.26.10
+  resolution: "@babel/parser@npm:7.26.10"
+  dependencies:
+    "@babel/types": "npm:^7.26.10"
+  bin:
+    parser: ./bin/babel-parser.js
+  checksum: 10c0/c47f5c0f63cd12a663e9dc94a635f9efbb5059d98086a92286d7764357c66bceba18ccbe79333e01e9be3bfb8caba34b3aaebfd8e62c3d5921c8cf907267be75
+  languageName: node
+  linkType: hard
+
 "@babel/runtime@npm:^7.12.5":
-  version: 7.24.6
-  resolution: "@babel/runtime@npm:7.24.6"
+  version: 7.26.10
+  resolution: "@babel/runtime@npm:7.26.10"
   dependencies:
     regenerator-runtime: "npm:^0.14.0"
-  checksum: 10c0/224ad205de33ea28979baaec89eea4c4d4e9482000dd87d15b97859365511cdd4d06517712504024f5d33a5fb9412f9b91c96f1d923974adf9359e1575cde049
+  checksum: 10c0/6dc6d88c7908f505c4f7770fb4677dfa61f68f659b943c2be1f2a99cb6680343462867abf2d49822adc435932919b36c77ac60125793e719ea8745f2073d3745
   languageName: node
   linkType: hard
 
@@ -353,6 +375,17 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@babel/template@npm:^7.26.9":
+  version: 7.26.9
+  resolution: "@babel/template@npm:7.26.9"
+  dependencies:
+    "@babel/code-frame": "npm:^7.26.2"
+    "@babel/parser": "npm:^7.26.9"
+    "@babel/types": "npm:^7.26.9"
+  checksum: 10c0/019b1c4129cc01ad63e17529089c2c559c74709d225f595eee017af227fee11ae8a97a6ab19ae6768b8aa22d8d75dcb60a00b28f52e9fa78140672d928bc1ae9
+  languageName: node
+  linkType: hard
+
 "@babel/traverse@npm:^7.24.7":
   version: 7.24.7
   resolution: "@babel/traverse@npm:7.24.7"
@@ -392,6 +425,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@babel/types@npm:^7.26.10":
+  version: 7.26.10
+  resolution: "@babel/types@npm:7.26.10"
+  dependencies:
+    "@babel/helper-string-parser": "npm:^7.25.9"
+    "@babel/helper-validator-identifier": "npm:^7.25.9"
+  checksum: 10c0/7a7f83f568bfc3dfabfaf9ae3a97ab5c061726c0afa7dcd94226d4f84a81559da368ed79671e3a8039d16f12476cf110381a377ebdea07587925f69628200dac
+  languageName: node
+  linkType: hard
+
 "@babel/types@npm:^7.8.3":
   version: 7.24.5
   resolution: "@babel/types@npm:7.24.5"
@@ -5436,13 +5479,13 @@ __metadata:
   linkType: hard
 
 "axios@npm:^1.6.0":
-  version: 1.7.4
-  resolution: "axios@npm:1.7.4"
+  version: 1.8.4
+  resolution: "axios@npm:1.8.4"
   dependencies:
     follow-redirects: "npm:^1.15.6"
     form-data: "npm:^4.0.0"
     proxy-from-env: "npm:^1.1.0"
-  checksum: 10c0/5ea1a93140ca1d49db25ef8e1bd8cfc59da6f9220159a944168860ad15a2743ea21c5df2967795acb15cbe81362f5b157fdebbea39d53117ca27658bab9f7f17
+  checksum: 10c0/450993c2ba975ffccaf0d480b68839a3b2435a5469a71fa2fb0b8a55cdb2c2ae47e609360b9c1e2b2534b73dfd69e2733a1cf9f8215bee0bcd729b72f801b0ce
   languageName: node
   linkType: hard
 

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export function hashObject(obj: Record<string, any>): string {`
`160`	`160`	`const hash = createHash("sha1");`
`161`	`161`	`updateSha1Hash(hash, obj);`
`162`	`162`
`163`		`- return hash.digest("hex");`
	`163`	`+ return hash.digest("base64");`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`export function once<T extends () => ReturnType<T>>(`