Merge branch 'main' into node-sdk-feature-definitions

pavkam · web-flow · commit 38750ac80d46 · 2025-03-25T17:12:49.000+07:00
diff --git a/packages/node-sdk/README.md b/packages/node-sdk/README.md
@@ -10,16 +10,13 @@ Install using `yarn` or `npm` with:
 
 > `yarn add -s @bucketco/node-sdk` or `npm install -s @bucketco/node-sdk`.
 
-Other supported languages/frameworks are in the
-[Supported languages](https://docs.bucket.co/quickstart/supported-languages)
-documentation pages.
+Other supported languages/frameworks are in the [Supported languages](https://docs.bucket.co/quickstart/supported-languages) documentation pages.
 
-You can also [use the HTTP API directly](https://docs.bucket.co/reference/http-tracking-api)
+You can also [use the HTTP API directly](https://docs.bucket.co/api/http-api)
 
 ## Basic usage
 
-To get started you need to obtain your secret key from the
-[environment settings](https://app.bucket.co/envs/current/settings/app-environments)
+To get started you need to obtain your secret key from the [environment settings](https://app.bucket.co/envs/current/settings/app-environments)
 in Bucket.
 
 > [!CAUTION]
@@ -138,8 +135,8 @@ await client.flush();
 
 ### Rate Limiting
 
-The SDK includes automatic rate limiting for feature events to prevent overwhelming the API. Rate limiting is applied per
-unique combination of feature key and context. The rate limiter window size is configurable:
+The SDK includes automatic rate limiting for feature events to prevent overwhelming the API.
+Rate limiting is applied per unique combination of feature key and context. The rate limiter window size is configurable:
 
 ```typescript
 const client = new BucketClient({
diff --git a/packages/node-sdk/src/utils.ts b/packages/node-sdk/src/utils.ts
@@ -160,7 +160,7 @@ export function hashObject(obj: Record<string, any>): string {
   const hash = createHash("sha1");
   updateSha1Hash(hash, obj);
 
-  return hash.digest("hex");
+  return hash.digest("base64");
 }
 
 export function once<T extends () => ReturnType<T>>(
diff --git a/packages/node-sdk/test/client.test.ts b/packages/node-sdk/test/client.test.ts
@@ -1596,9 +1596,7 @@ describe("BucketClient", () => {
       await client.initialize();
       client.getFeatures({ user, company, other: otherContext });
 
-      expect(isAllowedSpy).toHaveBeenCalledWith(
-        "d461e93fe41f6297ab43402d0fc6d63e2444e07d",
-      );
+      expect(isAllowedSpy).toHaveBeenCalledWith("1GHpP+QfYperQ0AtD8bWPiRE4H0=");
     });
 
     it("should return evaluated features when only user is defined", async () => {
diff --git a/packages/node-sdk/test/utils.test.ts b/packages/node-sdk/test/utils.test.ts
@@ -167,7 +167,7 @@ describe("hashObject", () => {
     expectedHash.update("name");
     expectedHash.update("Alice");
 
-    expect(hash).toBe(expectedHash.digest("hex"));
+    expect(hash).toBe(expectedHash.digest("base64"));
   });
 
   it("should hash arrays within objects", () => {
@@ -180,7 +180,7 @@ describe("hashObject", () => {
     expectedHash.update("2");
     expectedHash.update("3");
 
-    expect(hash).toBe(expectedHash.digest("hex"));
+    expect(hash).toBe(expectedHash.digest("base64"));
   });
 });
 

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export function hashObject(obj: Record<string, any>): string {`
`160`	`160`	`const hash = createHash("sha1");`
`161`	`161`	`updateSha1Hash(hash, obj);`
`162`	`162`
`163`		`- return hash.digest("hex");`
	`163`	`+ return hash.digest("base64");`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`export function once<T extends () => ReturnType<T>>(`