fix: change default open state to empty string for UncontrolledAccordion #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncontrolled accordion inherit properties of accordion component open prop is required in accordion and if we do not pass defaultOpenprop it initialize open to undefined which leads showing error/warning while testing the component in jest which uses the uncontrolled accordion
Contributor
Author
|
@illiteratewriter can you please review this PR, Fixed the minor issue related to uncontrolled accordion which is similar to my previous commit #2814. This changes insure proper functionality of |
…ate-for-uncontrolled-accordion
kevinrawal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
Problem
UncontrolledAccordionhas a propdefaultOpenwhich allows the user to set some accordion item to open by default, The current logic of UncontrolledAccordion inherits theAccordioncomponent's logic, We are initializing theopenprop of Accordion component using the defaultOpen prop, There will be a case where user don't pass any value for the defaultOpen as they don't want any default opens. This will work properly but the test cases for a component that uses theUncontrolledAccordionwill fail because if we don't pass any value fordefaultOpen, It sets open prop to undefined, and test fails as open is marked as required and we are passing it's value undefined.Fix
While initializing the open, we set its value to empty string instead of undefined, this will resolve the issue.
This PR is related to #2814, The same issue was resolved in the previous PR but a minor change is required in uncontrolled accordion.